fix(ViewHelper) create a new helper in case controller wasn't used #375
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmosolgo
pushed a commit
that referenced
this pull request
Oct 21, 2015
fix(ViewHelper) create a new helper in case controller wasn't used
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out there are some cases where the view helper will be used without the Rails controller lifecycle:
cellsgemIn these cases, fall back to a plain instantiation of the helper implementation. (No
setuporteardownin this case)Also:
ReactRailsUJSTestsince they're really testing the UJS, not theViewHelper